diff options
| author | Jose E. Marchesi <jose.marchesi@oracle.com> | 2024-01-23 21:56:24 +0100 |
|---|---|---|
| committer | Alexei Starovoitov <ast@kernel.org> | 2024-01-23 15:53:04 -0800 |
| commit | 756e34da5380e4c0ed2cfbe5259e1b015567a099 (patch) | |
| tree | 7a2fa6f17bda4a2e9fd2f656aebe254ad62e1c61 /tools/testing/selftests/bpf/progs/test_tcpbpf_kern.c | |
| parent | edb799035dd7d41c3e81e1bef83e2a2120b08abb (diff) | |
| download | linux-756e34da5380e4c0ed2cfbe5259e1b015567a099.tar.gz linux-756e34da5380e4c0ed2cfbe5259e1b015567a099.tar.bz2 linux-756e34da5380e4c0ed2cfbe5259e1b015567a099.zip | |
bpf: fix constraint in test_tcpbpf_kern.c
GCC emits a warning:
progs/test_tcpbpf_kern.c:60:9: error: ‘op’ is used uninitialized [-Werror=uninitialized]
when an uninialized op is used with a "+r" constraint. The + modifier
means a read-write operand, but that operand in the selftest is just
written to.
This patch changes the selftest to use a "=r" constraint. This
pacifies GCC.
Tested in bpf-next master.
No regressions.
Signed-off-by: Jose E. Marchesi <jose.marchesi@oracle.com>
Cc: Yonghong Song <yhs@meta.com>
Cc: Eduard Zingerman <eddyz87@gmail.com>
Cc: david.faust@oracle.com
Cc: cupertino.miranda@oracle.com
Acked-by: Yonghong Song <yonghong.song@linux.dev>
Link: https://lore.kernel.org/r/20240123205624.14746-1-jose.marchesi@oracle.com
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Diffstat (limited to 'tools/testing/selftests/bpf/progs/test_tcpbpf_kern.c')
| -rw-r--r-- | tools/testing/selftests/bpf/progs/test_tcpbpf_kern.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/testing/selftests/bpf/progs/test_tcpbpf_kern.c b/tools/testing/selftests/bpf/progs/test_tcpbpf_kern.c index cf7ed8cbb1fe..a3f3f43fc195 100644 --- a/tools/testing/selftests/bpf/progs/test_tcpbpf_kern.c +++ b/tools/testing/selftests/bpf/progs/test_tcpbpf_kern.c @@ -59,7 +59,7 @@ int bpf_testcb(struct bpf_sock_ops *skops) asm volatile ( "%[op] = *(u32 *)(%[skops] +96)" - : [op] "+r"(op) + : [op] "=r"(op) : [skops] "r"(skops) :); |