diff options
| author | Martin KaFai Lau <kafai@fb.com> | 2020-10-12 16:49:40 -0700 |
|---|---|---|
| committer | Daniel Borkmann <daniel@iogearbox.net> | 2020-10-15 20:53:15 +0200 |
| commit | 8a3feed90e75283f15f830b1051bf048e4127c91 (patch) | |
| tree | 111329e7cc442c40da9fca527c45fcbc133af62b /tools/testing/selftests/bpf/progs/test_misc_tcp_hdr_options.c | |
| parent | f58423aeab28f861b67933206f322f764f05787d (diff) | |
| download | linux-8a3feed90e75283f15f830b1051bf048e4127c91.tar.gz linux-8a3feed90e75283f15f830b1051bf048e4127c91.tar.bz2 linux-8a3feed90e75283f15f830b1051bf048e4127c91.zip | |
bpf, selftest: Fix flaky tcp_hdr_options test when adding addr to lo
The tcp_hdr_options test adds a "::eB9F" addr to the lo dev.
However, this non loopback address will have a race on ipv6 dad
which may lead to EADDRNOTAVAIL error from time to time.
Even nodad is used in the iproute2 command, there is still a race in
when the route will be added. This will then lead to ENETUNREACH from
time to time.
To avoid the above, this patch uses the default loopback address "::1"
to do the test.
Fixes: ad2f8eb0095e ("bpf: selftests: Tcp header options")
Reported-by: Andrii Nakryiko <andriin@fb.com>
Signed-off-by: Martin KaFai Lau <kafai@fb.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Acked-by: Andrii Nakryiko <andrii@kernel.org>
Link: https://lore.kernel.org/bpf/20201012234940.1707941-1-kafai@fb.com
Diffstat (limited to 'tools/testing/selftests/bpf/progs/test_misc_tcp_hdr_options.c')
| -rw-r--r-- | tools/testing/selftests/bpf/progs/test_misc_tcp_hdr_options.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/testing/selftests/bpf/progs/test_misc_tcp_hdr_options.c b/tools/testing/selftests/bpf/progs/test_misc_tcp_hdr_options.c index 72ec0178f653..6077a025092c 100644 --- a/tools/testing/selftests/bpf/progs/test_misc_tcp_hdr_options.c +++ b/tools/testing/selftests/bpf/progs/test_misc_tcp_hdr_options.c @@ -16,7 +16,7 @@ #define BPF_PROG_TEST_TCP_HDR_OPTIONS #include "test_tcp_hdr_options.h" -__u16 last_addr16_n = __bpf_htons(0xeB9F); +__u16 last_addr16_n = __bpf_htons(1); __u16 active_lport_n = 0; __u16 active_lport_h = 0; __u16 passive_lport_n = 0; |