diff options
| author | Hao Luo <haoluo@google.com> | 2020-09-03 13:05:28 -0700 |
|---|---|---|
| committer | Alexei Starovoitov <ast@kernel.org> | 2020-09-03 17:33:31 -0700 |
| commit | 95cec14b0308085c028c4d4fb3d09fad3902b4c3 (patch) | |
| tree | 84f648ba51fa70be277215e72b2113c532f319d4 /tools/testing/selftests/bpf/prog_tests/global_data_init.c | |
| parent | b4ff7ad7784689138ca2d9454833afc28cef6a68 (diff) | |
| download | linux-95cec14b0308085c028c4d4fb3d09fad3902b4c3.tar.gz linux-95cec14b0308085c028c4d4fb3d09fad3902b4c3.tar.bz2 linux-95cec14b0308085c028c4d4fb3d09fad3902b4c3.zip | |
selftests/bpf: Fix check in global_data_init.
The returned value of bpf_object__open_file() should be checked with
libbpf_get_error() rather than NULL. This fix prevents test_progs from
crash when test_global_data.o is not present.
Signed-off-by: Hao Luo <haoluo@google.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Acked-by: Andrii Nakryiko <andriin@fb.com>
Link: https://lore.kernel.org/bpf/20200903200528.747884-1-haoluo@google.com
Diffstat (limited to 'tools/testing/selftests/bpf/prog_tests/global_data_init.c')
| -rw-r--r-- | tools/testing/selftests/bpf/prog_tests/global_data_init.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/tools/testing/selftests/bpf/prog_tests/global_data_init.c b/tools/testing/selftests/bpf/prog_tests/global_data_init.c index 3bdaa5a40744..ee46b11f1f9a 100644 --- a/tools/testing/selftests/bpf/prog_tests/global_data_init.c +++ b/tools/testing/selftests/bpf/prog_tests/global_data_init.c @@ -12,7 +12,8 @@ void test_global_data_init(void) size_t sz; obj = bpf_object__open_file(file, NULL); - if (CHECK_FAIL(!obj)) + err = libbpf_get_error(obj); + if (CHECK_FAIL(err)) return; map = bpf_object__find_map_by_name(obj, "test_glo.rodata"); |