diff options
| author | Vladimir Oltean <vladimir.oltean@nxp.com> | 2021-08-10 16:13:55 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2021-08-11 14:44:58 +0100 |
| commit | 5d928ff4865641309e39e9ec8eec1022f8a0c0ac (patch) | |
| tree | 7d0e8c2a82f105cfb32f73f0167456abfe1ec443 /net/dsa/tag_lan9303.c | |
| parent | 6bef794da6d3bd347c18e93ad33483bd8903d9fd (diff) | |
| download | linux-5d928ff4865641309e39e9ec8eec1022f8a0c0ac.tar.gz linux-5d928ff4865641309e39e9ec8eec1022f8a0c0ac.tar.bz2 linux-5d928ff4865641309e39e9ec8eec1022f8a0c0ac.zip | |
net: dsa: create a helper for locating EtherType DSA headers on RX
It seems that protocol tagging driver writers are always surprised about
the formula they use to reach their EtherType header on RX, which
becomes apparent from the fact that there are comments in multiple
drivers that mention the same information.
Create a helper that returns a void pointer to skb->data - 2, as well as
centralize the explanation why that is the case.
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/dsa/tag_lan9303.c')
| -rw-r--r-- | net/dsa/tag_lan9303.c | 8 |
1 files changed, 1 insertions, 7 deletions
diff --git a/net/dsa/tag_lan9303.c b/net/dsa/tag_lan9303.c index e8ad3727433e..d06951273127 100644 --- a/net/dsa/tag_lan9303.c +++ b/net/dsa/tag_lan9303.c @@ -86,13 +86,7 @@ static struct sk_buff *lan9303_rcv(struct sk_buff *skb, struct net_device *dev) return NULL; } - /* '->data' points into the middle of our special VLAN tag information: - * - * ~ MAC src | 0x81 | 0x00 | 0xyy | 0xzz | ether type - * ^ - * ->data - */ - lan9303_tag = (__be16 *)(skb->data - 2); + lan9303_tag = dsa_etype_header_pos_rx(skb); if (lan9303_tag[0] != htons(ETH_P_8021Q)) { dev_warn_ratelimited(&dev->dev, "Dropping packet due to invalid VLAN marker\n"); |