summaryrefslogtreecommitdiff
path: root/net/core/failover.c
diff options
context:
space:
mode:
authorToke Høiland-Jørgensen <toke@redhat.com>2022-12-01 13:39:39 +0100
committerAlexei Starovoitov <ast@kernel.org>2022-12-04 18:52:20 -0800
commit578ce69ffda49d6c1a252490553290d1f27199f0 (patch)
tree15c4d639c3c0fdb7686d3e881f2dc73d77010f14 /net/core/failover.c
parent41d76c721c5c743470078d30e9bb8df08c489b1c (diff)
downloadlinux-578ce69ffda49d6c1a252490553290d1f27199f0.tar.gz
linux-578ce69ffda49d6c1a252490553290d1f27199f0.tar.bz2
linux-578ce69ffda49d6c1a252490553290d1f27199f0.zip
bpf: Add dummy type reference to nf_conn___init to fix type deduplication
The bpf_ct_set_nat_info() kfunc is defined in the nf_nat.ko module, and takes as a parameter the nf_conn___init struct, which is allocated through the bpf_xdp_ct_alloc() helper defined in the nf_conntrack.ko module. However, because kernel modules can't deduplicate BTF types between each other, and the nf_conn___init struct is not referenced anywhere in vmlinux BTF, this leads to two distinct BTF IDs for the same type (one in each module). This confuses the verifier, as described here: https://lore.kernel.org/all/87leoh372s.fsf@toke.dk/ As a workaround, add an explicit BTF_TYPE_EMIT for the type in net/filter.c, so the type definition gets included in vmlinux BTF. This way, both modules can refer to the same type ID (as they both build on top of vmlinux BTF), and the verifier is no longer confused. v2: - Use BTF_TYPE_EMIT (which is a statement so it has to be inside a function definition; use xdp_func_proto() for this, since this is mostly xdp-related). Fixes: 820dc0523e05 ("net: netfilter: move bpf_ct_set_nat_info kfunc in nf_nat_bpf.c") Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com> Link: https://lore.kernel.org/r/20221201123939.696558-1-toke@redhat.com Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Diffstat (limited to 'net/core/failover.c')
0 files changed, 0 insertions, 0 deletions