diff options
| author | Eric Dumazet <edumazet@google.com> | 2024-01-11 19:49:17 +0000 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2024-01-12 18:14:22 -0800 |
| commit | 724b00c12957973656d312dce2a110c75ae2c680 (patch) | |
| tree | b1523330ba770e29b564f252b87adef37cfa2e32 /fs/tracefs | |
| parent | 66ff70df1a919a066942844bb095d6fcb748d78d (diff) | |
| download | linux-724b00c12957973656d312dce2a110c75ae2c680.tar.gz linux-724b00c12957973656d312dce2a110c75ae2c680.tar.bz2 linux-724b00c12957973656d312dce2a110c75ae2c680.zip | |
mptcp: refine opt_mp_capable determination
OPTIONS_MPTCP_MPC is a combination of three flags.
It would be better to be strict about testing what
flag is expected, at least for code readability.
mptcp_parse_option() already makes the distinction.
- subflow_check_req() should use OPTION_MPTCP_MPC_SYN.
- mptcp_subflow_init_cookie_req() should use OPTION_MPTCP_MPC_ACK.
- subflow_finish_connect() should use OPTION_MPTCP_MPC_SYNACK
- subflow_syn_recv_sock should use OPTION_MPTCP_MPC_ACK
Suggested-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Acked-by: Paolo Abeni <pabeni@redhat.com>
Reviewed-by: Mat Martineau <martineau@kernel.org>
Fixes: 74c7dfbee3e1 ("mptcp: consolidate in_opt sub-options fields in a bitmask")
Link: https://lore.kernel.org/r/20240111194917.4044654-6-edumazet@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'fs/tracefs')
0 files changed, 0 insertions, 0 deletions