diff options
| author | Jakub Kicinski <kuba@kernel.org> | 2021-10-06 18:07:02 -0700 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2021-10-07 13:39:51 +0100 |
| commit | 894b0fb0921529928d596c155894ecae5444712f (patch) | |
| tree | 4f60713328ebffc2d45cff1abfb1067ed944bd84 /drivers/net/ethernet/microchip/enc28j60.c | |
| parent | b8eeac565b162b6a00423a5d9ed2d1284342bdfd (diff) | |
| download | linux-894b0fb0921529928d596c155894ecae5444712f.tar.gz linux-894b0fb0921529928d596c155894ecae5444712f.tar.bz2 linux-894b0fb0921529928d596c155894ecae5444712f.zip | |
ethernet: make more use of device_get_ethdev_address()
Convert a few drivers to device_get_ethdev_address(),
saving a few LoC.
The check if addr is valid in netsec is superfluous,
device_get_ethdev_addr() already checks that (in
fwnode_get_mac_addr()).
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/microchip/enc28j60.c')
| -rw-r--r-- | drivers/net/ethernet/microchip/enc28j60.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/drivers/net/ethernet/microchip/enc28j60.c b/drivers/net/ethernet/microchip/enc28j60.c index cca8aa70cfc9..634ac7649c43 100644 --- a/drivers/net/ethernet/microchip/enc28j60.c +++ b/drivers/net/ethernet/microchip/enc28j60.c @@ -1539,7 +1539,6 @@ static const struct net_device_ops enc28j60_netdev_ops = { static int enc28j60_probe(struct spi_device *spi) { - unsigned char macaddr[ETH_ALEN]; struct net_device *dev; struct enc28j60_net *priv; int ret = 0; @@ -1572,9 +1571,7 @@ static int enc28j60_probe(struct spi_device *spi) goto error_irq; } - if (!device_get_mac_address(&spi->dev, macaddr)) - eth_hw_addr_set(dev, macaddr); - else + if (device_get_ethdev_address(&spi->dev, dev)) eth_hw_addr_random(dev); enc28j60_set_hw_macaddr(dev); |