diff options
| author | Vitaly Lifshits <vitaly.lifshits@intel.com> | 2024-10-01 20:05:31 +0300 |
|---|---|---|
| committer | Tony Nguyen <anthony.l.nguyen@intel.com> | 2024-11-13 10:30:21 -0800 |
| commit | ade6fded7957fd10a152de98513e4af3ff76ab71 (patch) | |
| tree | 779262727c44ce6c3d4fafa09218390eb6aca2b1 /drivers/net/ethernet/intel/igc/igc_diag.c | |
| parent | 4b2c75ffeaadfce0ffdd97fbd0bbcad5c4f83131 (diff) | |
| download | linux-ade6fded7957fd10a152de98513e4af3ff76ab71.tar.gz linux-ade6fded7957fd10a152de98513e4af3ff76ab71.tar.bz2 linux-ade6fded7957fd10a152de98513e4af3ff76ab71.zip | |
igc: remove autoneg parameter from igc_mac_info
Since the igc driver doesn't support forced speed configuration and
its current related hardware doesn't support it either, there is no
use of the mac.autoneg parameter. Moreover, in one case this usage
might result in a NULL pointer dereference due to an uninitialized
function pointer, phy.ops.force_speed_duplex.
Therefore, remove this parameter from the igc code.
Signed-off-by: Vitaly Lifshits <vitaly.lifshits@intel.com>
Tested-by: Mor Bar-Gabay <morx.bar.gabay@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
Diffstat (limited to 'drivers/net/ethernet/intel/igc/igc_diag.c')
| -rw-r--r-- | drivers/net/ethernet/intel/igc/igc_diag.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/net/ethernet/intel/igc/igc_diag.c b/drivers/net/ethernet/intel/igc/igc_diag.c index cc621970c0cd..a43d7244ee70 100644 --- a/drivers/net/ethernet/intel/igc/igc_diag.c +++ b/drivers/net/ethernet/intel/igc/igc_diag.c @@ -173,8 +173,7 @@ bool igc_link_test(struct igc_adapter *adapter, u64 *data) *data = 0; /* add delay to give enough time for autonegotioation to finish */ - if (adapter->hw.mac.autoneg) - ssleep(5); + ssleep(5); link_up = igc_has_link(adapter); if (!link_up) { |