summaryrefslogtreecommitdiff
path: root/drivers/net/ethernet/amd/lance.c
diff options
context:
space:
mode:
authorVladimir Oltean <vladimir.oltean@nxp.com>2023-05-16 18:44:10 +0300
committerDavid S. Miller <davem@davemloft.net>2023-05-17 12:59:53 +0100
commitc46e78ba9a7a09da4f192dc8df15c4e8a07fb9e0 (patch)
treedb66f8b7295732da1fa31b67fc50fb9891c7ca8f /drivers/net/ethernet/amd/lance.c
parent60829145f1e2650b31ebe6a0ec70a9725b38fa2c (diff)
downloadlinux-c46e78ba9a7a09da4f192dc8df15c4e8a07fb9e0.tar.gz
linux-c46e78ba9a7a09da4f192dc8df15c4e8a07fb9e0.tar.bz2
linux-c46e78ba9a7a09da4f192dc8df15c4e8a07fb9e0.zip
net: pcs: xpcs: fix C73 AN not getting enabled
The XPCS expects clause 73 (copper backplane) autoneg to follow the ethtool autoneg bit. It actually did that until the blamed commit inaptly replaced state->an_enabled (coming from ethtool) with phylink_autoneg_inband() (coming from the device tree or struct phylink_config), as part of an unrelated phylink_pcs API conversion. Russell King suggests that state->an_enabled from the original code was just a proxy for the ethtool Autoneg bit, and that the correct way of restoring the functionality is to check for this bit in the advertising mask. Fixes: 11059740e616 ("net: pcs: xpcs: convert to phylink_pcs_ops") Link: https://lore.kernel.org/netdev/ZGNt2MFeRolKGFck@shell.armlinux.org.uk/ Suggested-by: Russell King (Oracle) <linux@armlinux.org.uk> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/amd/lance.c')
0 files changed, 0 insertions, 0 deletions