diff options
| author | Gustavo A. R. Silva <gustavoars@kernel.org> | 2023-09-17 15:21:36 -0600 |
|---|---|---|
| committer | Leon Romanovsky <leon@kernel.org> | 2023-09-19 10:33:45 +0300 |
| commit | 81760bedc65194ff38e1e4faefd5f9f0c95c19a4 (patch) | |
| tree | d92360dcda24c6cb5eb4428626fc78c126abd26a /drivers/infiniband/core/device.c | |
| parent | 4ececeb839868ad235515f5bb332530f2ac11253 (diff) | |
| download | linux-81760bedc65194ff38e1e4faefd5f9f0c95c19a4.tar.gz linux-81760bedc65194ff38e1e4faefd5f9f0c95c19a4.tar.bz2 linux-81760bedc65194ff38e1e4faefd5f9f0c95c19a4.zip | |
RDMA/core: Use size_{add,sub,mul}() in calls to struct_size()
If, for any reason, the open-coded arithmetic causes a wraparound,
the protection that `struct_size()` provides against potential integer
overflows is defeated. Fix this by hardening calls to `struct_size()`
with `size_add()`, `size_sub()` and `size_mul()`.
Fixes: 467f432a521a ("RDMA/core: Split port and device counter sysfs attributes")
Fixes: a4676388e2e2 ("RDMA/core: Simplify how the gid_attrs sysfs is created")
Fixes: e9dd5daf884c ("IB/umad: Refactor code to use cdev_device_add()")
Fixes: 324e227ea7c9 ("RDMA/device: Add ib_device_get_by_netdev()")
Fixes: 5aad26a7eac5 ("IB/core: Use struct_size() in kzalloc()")
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Link: https://lore.kernel.org/r/ZQdt4NsJFwwOYxUR@work
Signed-off-by: Leon Romanovsky <leon@kernel.org>
Diffstat (limited to 'drivers/infiniband/core/device.c')
| -rw-r--r-- | drivers/infiniband/core/device.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/infiniband/core/device.c b/drivers/infiniband/core/device.c index a666847bd714..010718738d04 100644 --- a/drivers/infiniband/core/device.c +++ b/drivers/infiniband/core/device.c @@ -804,7 +804,7 @@ static int alloc_port_data(struct ib_device *device) * empty slots at the beginning. */ pdata_rcu = kzalloc(struct_size(pdata_rcu, pdata, - rdma_end_port(device) + 1), + size_add(rdma_end_port(device), 1)), GFP_KERNEL); if (!pdata_rcu) return -ENOMEM; |