diff options
author | Imre Deak <imre.deak@intel.com> | 2024-07-12 16:57:22 +0300 |
---|---|---|
committer | Imre Deak <imre.deak@intel.com> | 2024-07-22 10:41:07 +0300 |
commit | 2885d283cce544cf3619f35f0acb3d073de036e1 (patch) | |
tree | 0e710d9ed560a139be31ab5271fe8ee1cae95527 /drivers/gpu/drm/i915/display/intel_dp_link_training.c | |
parent | d43caea1faf5c31dc02aa1adb8bb1aa1c33bf86f (diff) | |
download | linux-2885d283cce544cf3619f35f0acb3d073de036e1.tar.gz linux-2885d283cce544cf3619f35f0acb3d073de036e1.tar.bz2 linux-2885d283cce544cf3619f35f0acb3d073de036e1.zip |
drm/i915/dp: Retrain SST links via a modeset commit
Instead of direct calls of the link training functions, use a modeset
commit to retrain a DP link in SST mode, similarly to how this is done
in DP-MST mode. Originally the current way was chosen presumedly,
because there wasn't a well-established way in place for the driver to
do an internal (vs. userspace/kernel client) commit. Since then such
internal commits became a common place (initial-, HDMI/TC link reset
commit), so there is no reason to handle the DP-SST link-retraining case
differently.
At the end of the current sequence the HW reported a FIFO underrun -
without other issues visible to users - because during retraining the
link's encoder/port was disabled/re-enabled without also
disabling/re-enabling the corresponding pipe/transcoder (as required by
the spec); the corresponding underrun error message was suppressed as a
known issue. Based on Ankit's test on DG2 the underrun error was still
reported as it got detected with some (vblank) delay wrt. other
platforms. Switching to a modeset commit resolves these underrun related
issues.
Cc: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Suraj Kandpal <suraj.kandpal@intel.com>
Signed-off-by: Imre Deak <imre.deak@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240712135724.660399-1-imre.deak@intel.com
Diffstat (limited to 'drivers/gpu/drm/i915/display/intel_dp_link_training.c')
0 files changed, 0 insertions, 0 deletions