diff options
| author | Ian Chen <ian.chen@amd.com> | 2021-12-21 11:17:30 +0800 |
|---|---|---|
| committer | Alex Deucher <alexander.deucher@amd.com> | 2022-01-18 17:43:36 -0500 |
| commit | c1a20f707ac33b1fec1d78bab74e07656c237801 (patch) | |
| tree | 2b2d757ea9f5cf1615d18efb103eeb59386422f3 /drivers/gpu/drm/amd/display/dc/dm_helpers.h | |
| parent | f369e4eba89a6fc1cac619db86c00a964d1fc0a2 (diff) | |
| download | linux-c1a20f707ac33b1fec1d78bab74e07656c237801.tar.gz linux-c1a20f707ac33b1fec1d78bab74e07656c237801.tar.bz2 linux-c1a20f707ac33b1fec1d78bab74e07656c237801.zip | |
drm/amd/display: modify SMU_TIMEOUT macro.
[WHY]
If some SMU features are not enabled, SMU will return fail to that
message.
[HOW]
SMU_TIMEOUT macro will treat "return fail" as timeout also.
Correct the macro to only report timeout case.
Reviewed-by: Jun Lei <Jun.Lei@amd.com>
Acked-by: Wayne Lin <wayne.lin@amd.com>
Signed-off-by: Ian Chen <ian.chen@amd.com>
Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Diffstat (limited to 'drivers/gpu/drm/amd/display/dc/dm_helpers.h')
| -rw-r--r-- | drivers/gpu/drm/amd/display/dc/dm_helpers.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/gpu/drm/amd/display/dc/dm_helpers.h b/drivers/gpu/drm/amd/display/dc/dm_helpers.h index 7f94e3f70d7f..a5497ba89f15 100644 --- a/drivers/gpu/drm/amd/display/dc/dm_helpers.h +++ b/drivers/gpu/drm/amd/display/dc/dm_helpers.h @@ -170,9 +170,9 @@ bool dm_helpers_dmub_outbox_interrupt_control(struct dc_context *ctx, bool enabl void dm_helpers_smu_timeout(struct dc_context *ctx, unsigned int msg_id, unsigned int param, unsigned int timeout_us); -// 0x1 = Result_OK, 0xFE = Result_UnkmownCmd +// 0x1 = Result_OK, 0xFE = Result_UnkmownCmd, 0x0 = Status_Busy #define IS_SMU_TIMEOUT(result) \ - (!(result == 0x1 || result == 0xFE)) + (result == 0x0) int dm_helper_dmub_aux_transfer_sync( struct dc_context *ctx, |