diff options
| author | Sunil Khatri <sunil.khatri@amd.com> | 2024-10-17 19:17:22 +0530 |
|---|---|---|
| committer | Alex Deucher <alexander.deucher@amd.com> | 2024-10-22 17:50:39 -0400 |
| commit | e095026f0066eca05268b20a6f378cf31bedc54b (patch) | |
| tree | ea958eefac83c657404dccf764bea116a4db3b35 /drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c | |
| parent | dad01f93f432d4a2456860f7f55fdb762d2982a4 (diff) | |
| download | linux-e095026f0066eca05268b20a6f378cf31bedc54b.tar.gz linux-e095026f0066eca05268b20a6f378cf31bedc54b.tar.bz2 linux-e095026f0066eca05268b20a6f378cf31bedc54b.zip | |
drm/amdgpu: validate suspend before function call
Before making a function call to suspend, validate
the function pointer like we do in sw_init.
Use the helper function amdgpu_ip_block_suspend where
same checks and calls are repeated.
Signed-off-by: Sunil Khatri <sunil.khatri@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Diffstat (limited to 'drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c')
| -rw-r--r-- | drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c | 9 |
1 files changed, 2 insertions, 7 deletions
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c index 3e2724590dbf..99e75d899c9f 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c @@ -28,7 +28,7 @@ static int amdgpu_reset_xgmi_reset_on_init_suspend(struct amdgpu_device *adev) { - int i, r; + int i; for (i = adev->num_ip_blocks - 1; i >= 0; i--) { if (!adev->ip_blocks[i].status.valid) @@ -40,12 +40,7 @@ static int amdgpu_reset_xgmi_reset_on_init_suspend(struct amdgpu_device *adev) continue; /* XXX handle errors */ - r = adev->ip_blocks[i].version->funcs->suspend(&adev->ip_blocks[i]); - /* XXX handle errors */ - if (r) { - dev_err(adev->dev, "suspend of IP block <%s> failed %d", - adev->ip_blocks[i].version->funcs->name, r); - } + amdgpu_ip_block_suspend(&adev->ip_blocks[i]); adev->ip_blocks[i].status.hw = false; } |