diff options
| author | Kunwu Chan <chentao@kylinos.cn> | 2023-11-26 17:37:19 +0800 |
|---|---|---|
| committer | Michael Ellerman <mpe@ellerman.id.au> | 2023-12-13 22:19:43 +1100 |
| commit | 0a233867a39078ebb0f575e2948593bbff5826b3 (patch) | |
| tree | d7770ef74b874278837737de33753d9ba506f120 /arch/powerpc | |
| parent | e123015c0ba859cf48aa7f89c5016cc6e98e018d (diff) | |
| download | linux-0a233867a39078ebb0f575e2948593bbff5826b3.tar.gz linux-0a233867a39078ebb0f575e2948593bbff5826b3.tar.bz2 linux-0a233867a39078ebb0f575e2948593bbff5826b3.zip | |
powerpc/imc-pmu: Add a null pointer check in update_events_in_group()
kasprintf() returns a pointer to dynamically allocated memory
which can be NULL upon failure.
Fixes: 885dcd709ba9 ("powerpc/perf: Add nest IMC PMU support")
Signed-off-by: Kunwu Chan <chentao@kylinos.cn>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://msgid.link/20231126093719.1440305-1-chentao@kylinos.cn
Diffstat (limited to 'arch/powerpc')
| -rw-r--r-- | arch/powerpc/perf/imc-pmu.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/arch/powerpc/perf/imc-pmu.c b/arch/powerpc/perf/imc-pmu.c index 5d12ca386c1f..8664a7d297ad 100644 --- a/arch/powerpc/perf/imc-pmu.c +++ b/arch/powerpc/perf/imc-pmu.c @@ -299,6 +299,8 @@ static int update_events_in_group(struct device_node *node, struct imc_pmu *pmu) attr_group->attrs = attrs; do { ev_val_str = kasprintf(GFP_KERNEL, "event=0x%x", pmu->events[i].value); + if (!ev_val_str) + continue; dev_str = device_str_attr_create(pmu->events[i].name, ev_val_str); if (!dev_str) continue; @@ -306,6 +308,8 @@ static int update_events_in_group(struct device_node *node, struct imc_pmu *pmu) attrs[j++] = dev_str; if (pmu->events[i].scale) { ev_scale_str = kasprintf(GFP_KERNEL, "%s.scale", pmu->events[i].name); + if (!ev_scale_str) + continue; dev_str = device_str_attr_create(ev_scale_str, pmu->events[i].scale); if (!dev_str) continue; @@ -315,6 +319,8 @@ static int update_events_in_group(struct device_node *node, struct imc_pmu *pmu) if (pmu->events[i].unit) { ev_unit_str = kasprintf(GFP_KERNEL, "%s.unit", pmu->events[i].name); + if (!ev_unit_str) + continue; dev_str = device_str_attr_create(ev_unit_str, pmu->events[i].unit); if (!dev_str) continue; |