summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorIan Rogers <irogers@google.com>2023-10-09 11:39:18 -0700
committerNamhyung Kim <namhyung@kernel.org>2023-10-12 10:01:57 -0700
commit97fe038374bdf43fd025ac0e7aebf8bfbdd6d54f (patch)
tree5528b486ab4e61879a00083f6f95ffeebafa5b0c
parentc4b5140c6eac2f757d9706c6c783b60554c48cb7 (diff)
downloadlinux-97fe038374bdf43fd025ac0e7aebf8bfbdd6d54f.tar.gz
linux-97fe038374bdf43fd025ac0e7aebf8bfbdd6d54f.tar.bz2
linux-97fe038374bdf43fd025ac0e7aebf8bfbdd6d54f.zip
perf trace-event-info: Avoid passing NULL value to closedir
If opendir failed then closedir was passed NULL which is erroneous. Caught by clang-tidy. Signed-off-by: Ian Rogers <irogers@google.com> Acked-by: Namhyung Kim <namhyung@kernel.org> Cc: Ravi Bangoria <ravi.bangoria@amd.com> Cc: Nick Desaulniers <ndesaulniers@google.com> Cc: Yang Jihong <yangjihong1@huawei.com> Cc: Huacai Chen <chenhuacai@kernel.org> Cc: Nathan Chancellor <nathan@kernel.org> Cc: Kan Liang <kan.liang@linux.intel.com> Cc: llvm@lists.linux.dev Cc: Ming Wang <wangming01@loongson.cn> Cc: Tom Rix <trix@redhat.com> Cc: bpf@vger.kernel.org Link: https://lore.kernel.org/r/20231009183920.200859-18-irogers@google.com Signed-off-by: Namhyung Kim <namhyung@kernel.org>
-rw-r--r--tools/perf/util/trace-event-info.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/tools/perf/util/trace-event-info.c b/tools/perf/util/trace-event-info.c
index 319ccf09a435..c8755679281e 100644
--- a/tools/perf/util/trace-event-info.c
+++ b/tools/perf/util/trace-event-info.c
@@ -313,7 +313,8 @@ static int record_event_files(struct tracepoint_path *tps)
}
err = 0;
out:
- closedir(dir);
+ if (dir)
+ closedir(dir);
put_tracing_file(path);
return err;