diff options
| author | Eric Dumazet <edumazet@google.com> | 2023-04-05 07:15:56 +0000 |
|---|---|---|
| committer | Paolo Abeni <pabeni@redhat.com> | 2023-04-06 13:19:25 +0200 |
| commit | 905a9eb5f636f3312964b162362e4d6ca4e37378 (patch) | |
| tree | 739433ae2e5cb89b906067537598614606773948 | |
| parent | 0f72997036f32264fbecefb6a329de8e8d1bb5ce (diff) | |
| download | linux-905a9eb5f636f3312964b162362e4d6ca4e37378.tar.gz linux-905a9eb5f636f3312964b162362e4d6ca4e37378.tar.bz2 linux-905a9eb5f636f3312964b162362e4d6ca4e37378.zip | |
selftests/net: fix typo in tcp_mmap
kernel test robot reported the following warning:
All warnings (new ones prefixed by >>):
tcp_mmap.c: In function 'child_thread':
>> tcp_mmap.c:211:61: warning: 'lu' may be used uninitialized in this function [-Wmaybe-uninitialized]
211 | zc.length = min(chunk_size, FILE_SZ - lu);
We want to read FILE_SZ bytes, so the correct expression
should be (FILE_SZ - total)
Fixes: 5c5945dc695c ("selftests/net: Add SHA256 computation over data sent in tcp_mmap")
Reported-by: kernel test robot <lkp@intel.com>
Link: https://lore.kernel.org/oe-kbuild-all/202304042104.UFIuevBp-lkp@intel.com/
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Xiaoyan Li <lixiaoyan@google.com>
Cc: Kuniyuki Iwashima <kuniyu@amazon.com>
Link: https://lore.kernel.org/r/20230405071556.1019623-1-edumazet@google.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
| -rw-r--r-- | tools/testing/selftests/net/tcp_mmap.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/testing/selftests/net/tcp_mmap.c b/tools/testing/selftests/net/tcp_mmap.c index 607cc9ad8d1b..6e59b1461dcc 100644 --- a/tools/testing/selftests/net/tcp_mmap.c +++ b/tools/testing/selftests/net/tcp_mmap.c @@ -208,7 +208,7 @@ void *child_thread(void *arg) memset(&zc, 0, sizeof(zc)); zc.address = (__u64)((unsigned long)addr); - zc.length = min(chunk_size, FILE_SZ - lu); + zc.length = min(chunk_size, FILE_SZ - total); res = getsockopt(fd, IPPROTO_TCP, TCP_ZEROCOPY_RECEIVE, &zc, &zc_len); |