diff options
| author | Hans Verkuil <hverkuil-cisco@xs4all.nl> | 2023-01-26 13:56:20 +0100 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab@kernel.org> | 2023-02-08 08:38:56 +0100 |
| commit | 5949afa34a0aebe239e3f5b54deb543a464d2125 (patch) | |
| tree | 5522617b1ea243ee2b320753d708718377ddb1d1 | |
| parent | 55869f435d7f6a121722c687e3ac056168e473eb (diff) | |
| download | linux-5949afa34a0aebe239e3f5b54deb543a464d2125.tar.gz linux-5949afa34a0aebe239e3f5b54deb543a464d2125.tar.bz2 linux-5949afa34a0aebe239e3f5b54deb543a464d2125.zip | |
media: mediatek: mdp3: replace return by goto for proper unwind
An error was returned at one point without going through the
goto label for proper unwinding.
This fixes a smatch warning:
mtk-mdp3-comp.c:1005 mdp_comp_config() warn: missing unwind goto?
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Cc: Moudy Ho <moudy.ho@mediatek.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
| -rw-r--r-- | drivers/media/platform/mediatek/mdp3/mtk-mdp3-comp.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/media/platform/mediatek/mdp3/mtk-mdp3-comp.c b/drivers/media/platform/mediatek/mdp3/mtk-mdp3-comp.c index 7bc05f42a23c..091a68685590 100644 --- a/drivers/media/platform/mediatek/mdp3/mtk-mdp3-comp.c +++ b/drivers/media/platform/mediatek/mdp3/mtk-mdp3-comp.c @@ -1002,7 +1002,8 @@ int mdp_comp_config(struct mdp_dev *mdp) if (!pdev) { dev_warn(dev, "can't find platform device of node:%s\n", node->name); - return -ENODEV; + ret = -ENODEV; + goto err_init_comps; } comp->comp_dev = &pdev->dev; |