diff options
| author | Ajay Agarwal <ajayagarwal@google.com> | 2023-05-04 16:42:58 +0530 |
|---|---|---|
| committer | Bjorn Helgaas <bhelgaas@google.com> | 2023-05-18 16:51:50 -0500 |
| commit | 25edb25d7972414022c1fa098e2d85876bd7fab2 (patch) | |
| tree | 2e05e568c4bf4d778653137bf1fafb3d4564cdb1 | |
| parent | fb097dcd5a28c0a2325632405c76a66777a6bed9 (diff) | |
| download | linux-25edb25d7972414022c1fa098e2d85876bd7fab2.tar.gz linux-25edb25d7972414022c1fa098e2d85876bd7fab2.tar.bz2 linux-25edb25d7972414022c1fa098e2d85876bd7fab2.zip | |
PCI/ASPM: Set only ASPM_STATE_L1 when driver enables L1
Previously pci_enable_link_state(PCIE_LINK_STATE_L1) enabled L1SS as well
as L1. Enable only ASPM_STATE_L1 when the caller enables L1.
The only current caller is vmd_pm_enable_quirk(), which enables *all* ASPM
states, so this should have no functional effect.
[bhelgaas: commit log]
Link: https://lore.kernel.org/r/20230504111301.229358-3-ajayagarwal@google.com
Signed-off-by: Ajay Agarwal <ajayagarwal@google.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
| -rw-r--r-- | drivers/pci/pcie/aspm.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/pci/pcie/aspm.c b/drivers/pci/pcie/aspm.c index 8c8352eeee52..a341019f9d9b 100644 --- a/drivers/pci/pcie/aspm.c +++ b/drivers/pci/pcie/aspm.c @@ -1173,8 +1173,7 @@ int pci_enable_link_state(struct pci_dev *pdev, int state) if (state & PCIE_LINK_STATE_L0S) link->aspm_default |= ASPM_STATE_L0S; if (state & PCIE_LINK_STATE_L1) - /* L1 PM substates require L1 */ - link->aspm_default |= ASPM_STATE_L1 | ASPM_STATE_L1SS; + link->aspm_default |= ASPM_STATE_L1; if (state & PCIE_LINK_STATE_L1_1) link->aspm_default |= ASPM_STATE_L1_1; if (state & PCIE_LINK_STATE_L1_2) |