From 10cbc378ad0daf0e80f5ceed92d70fdbf573df88 Mon Sep 17 00:00:00 2001 From: gabrielgio Date: Sun, 18 Jul 2021 19:56:59 +0200 Subject: ref: Move to OO implementation Heavily inspired by the `youtube-dl` implementation I moved to OO implementation where now every source type has its own class, making easy to add new providers. Also new it has a fallback back, where if no provider is chose it will try to download with `YoutubeDlProvideBase`. Add `_TEST` to each class to make it easy to add test to new providers. --- test/test_download.py | 53 -------------------------------------------------- test/test_providers.py | 23 ++++++++++++++++++++++ 2 files changed, 23 insertions(+), 53 deletions(-) delete mode 100644 test/test_download.py create mode 100644 test/test_providers.py (limited to 'test') diff --git a/test/test_download.py b/test/test_download.py deleted file mode 100644 index f13ed67..0000000 --- a/test/test_download.py +++ /dev/null @@ -1,53 +0,0 @@ -import os - -import pytest - -from importer.downloader import SourceType, Downloader - -@pytest.fixture -def mock_ydl_download(mocker): - # this function is responsible for downloading the file - return mocker.patch('importer.downloader.youtube_dl.YoutubeDL.process_info') - - -@pytest.mark.parametrize('url,source_type', [ - ("https://i.redd.it/pjj1ll1b2rr41.jpg", SourceType.IREDDIT), - ("https://gfycat.com/presentdangerousdromedary", SourceType.GFYCAT), - ("https://i.imgur.com/fXLMjfp.jpg", SourceType.IMAGURJPG), - ("https://redgifs.com/watch/ripesnivelingfiddlercrab", SourceType.REDGIFS), - ("https://www.youtube.com/watch?v=oLkdqptmfng", SourceType.YOUTUBE), - ("https://v.redd.it/42j6r7i8z7151", SourceType.VREDDIT), - ("https://www.reddit.com/gallery/mik7c9", SourceType.GREDDIT), - ("https://duckduckgo.com", SourceType.UNKNOWN), -]) -def test_source_type(url, source_type): - with Downloader(url, "1-A") as d: - assert d.source_type == source_type - - -@pytest.mark.parametrize('url,paths', [ - ("https://gfycat.com/presentdangerousdromedary", ["source_presentdangerousdromedary.mp4"]), - ("https://redgifs.com/watch/ripesnivelingfiddlercrab", ["source_RipeSnivelingFiddlercrab.mp4", 'source_RipeSnivelingFiddlercrab-mobile.mp4']), - ("https://www.youtube.com/watch?v=oLkdqptmfng", ["source_oLkdqptmfng.mp4"]), - ("https://v.redd.it/42j6r7i8z7151", ["source_42j6r7i8z7151.mp4"]), -]) -def test_download_youtube_dl(url, paths, mock_ydl_download): - with Downloader(url, "1-A") as d: - assert d.downloaded is False - d.download() - assert d.downloaded is True - assert d.paths == paths - mock_ydl_download.assert_called() - - -@pytest.mark.parametrize('url,path', [ - ("https://i.redd.it/pjj1ll1b2rr41.jpg", "source_pjj1ll1b2rr41.jpg"), - ("https://i.imgur.com/fXLMjfp.jpg", "source_fXLMjfp.jpg"), -]) -def test_download_raw_data(url, path): - with Downloader(url, "1-A") as d: - assert d.downloaded is False - d.download() - assert d.paths == [path] - assert d.downloaded is True - diff --git a/test/test_providers.py b/test/test_providers.py new file mode 100644 index 0000000..9a5084e --- /dev/null +++ b/test/test_providers.py @@ -0,0 +1,23 @@ +import praw +import pytest + +from importer.downloader import Downloader +import importer.providers as providers +from importer.providers import ProviderBase + + +@pytest.mark.parametrize("provider", + [ + providers.IReddit, + providers.Imgur, + providers.RawImageProviderBase, + providers.RedGifs, + providers.Youtube, + providers.YoutubeDlProviderBase + ]) +def test_provider(provider): + for test in provider._TEST: + with provider(url=test['url']) as p: + p.download() + assert p.downloaded + assert p.paths == test['paths'] -- cgit v1.2.3