diff options
| author | Nathan Chancellor <nathan@kernel.org> | 2021-08-10 17:55:05 -0700 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2021-08-11 09:42:32 +0200 |
| commit | 3a330ece235e8d2647d7e9e287e226d77b7cae9f (patch) | |
| tree | 95cfd158dea26dd511c9bb8edd611541bd625ca4 /drivers | |
| parent | e3027f25c6f756056a314b82c11971349cca7a62 (diff) | |
| download | linux-3a330ece235e8d2647d7e9e287e226d77b7cae9f.tar.gz linux-3a330ece235e8d2647d7e9e287e226d77b7cae9f.tar.bz2 linux-3a330ece235e8d2647d7e9e287e226d77b7cae9f.zip | |
staging: r8188eu: os_dep: Hoist vmalloc.h include into osdep_service.h
After commit 71f09c5ae9d2 ("staging: r8188eu: Remove wrapper around
vfree"), the driver fails to build on Hexagon due to an implicit
declaration in several different files:
drivers/staging/r8188eu/core/rtw_mlme.c:129:3: error: implicit
declaration of function 'vfree'
[-Werror,-Wimplicit-function-declaration]
vfree(pmlmepriv->free_bss_buf);
^
1 error generated.
Previously, vfree() was only called in osdep_service.c, which includes
vmalloc.h for vmalloc() and vfree(). Now, the driver relies on vfree()
getting implicitly included from another file.
Hoist the vmalloc.h include from osdep_service.c to osdep_service.h so
that the driver continues to build fine on all architectures.
Fixes: 71f09c5ae9d2 ("staging: r8188eu: Remove wrapper around vfree")
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Link: https://lore.kernel.org/r/20210811005505.3953122-1-nathan@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/staging/r8188eu/include/osdep_service.h | 1 | ||||
| -rw-r--r-- | drivers/staging/r8188eu/os_dep/osdep_service.c | 1 |
2 files changed, 1 insertions, 1 deletions
diff --git a/drivers/staging/r8188eu/include/osdep_service.h b/drivers/staging/r8188eu/include/osdep_service.h index 6399f645cd40..157ffe46c3d2 100644 --- a/drivers/staging/r8188eu/include/osdep_service.h +++ b/drivers/staging/r8188eu/include/osdep_service.h @@ -39,6 +39,7 @@ #include <linux/interrupt.h> /* for struct tasklet_struct */ #include <linux/ip.h> #include <linux/kthread.h> +#include <linux/vmalloc.h> #include <linux/usb.h> #include <linux/usb/ch9.h> diff --git a/drivers/staging/r8188eu/os_dep/osdep_service.c b/drivers/staging/r8188eu/os_dep/osdep_service.c index 910da0f0004a..9ea4e1a7c45f 100644 --- a/drivers/staging/r8188eu/os_dep/osdep_service.c +++ b/drivers/staging/r8188eu/os_dep/osdep_service.c @@ -6,7 +6,6 @@ #include "../include/osdep_service.h" #include "../include/drv_types.h" #include "../include/recv_osdep.h" -#include "../include/linux/vmalloc.h" #include "../include/rtw_ioctl_set.h" /* |