diff options
| author | Eric Dumazet <edumazet@google.com> | 2023-09-22 22:03:53 +0000 |
|---|---|---|
| committer | Paolo Abeni <pabeni@redhat.com> | 2023-10-03 10:05:22 +0200 |
| commit | cbc3a153222805d65f821e10f4f78b6afce06f86 (patch) | |
| tree | 37e010c36a217f5b19ab5a380e85dd0aa9b79389 | |
| parent | 35766690d675f63c111afa0a2f5286b74a5b5cc2 (diff) | |
| download | linux-cbc3a153222805d65f821e10f4f78b6afce06f86.tar.gz linux-cbc3a153222805d65f821e10f4f78b6afce06f86.tar.bz2 linux-cbc3a153222805d65f821e10f4f78b6afce06f86.zip | |
tcp_metrics: add missing barriers on delete
When removing an item from RCU protected list, we must prevent
store-tearing, using rcu_assign_pointer() or WRITE_ONCE().
Fixes: 04f721c671656 ("tcp_metrics: Rewrite tcp_metrics_flush_all")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: David Ahern <dsahern@kernel.org>
Acked-by: Neal Cardwell <ncardwell@google.com>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
| -rw-r--r-- | net/ipv4/tcp_metrics.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/net/ipv4/tcp_metrics.c b/net/ipv4/tcp_metrics.c index c196759f1d3b..4bfa2fb27de5 100644 --- a/net/ipv4/tcp_metrics.c +++ b/net/ipv4/tcp_metrics.c @@ -908,7 +908,7 @@ static void tcp_metrics_flush_all(struct net *net) match = net ? net_eq(tm_net(tm), net) : !refcount_read(&tm_net(tm)->ns.count); if (match) { - *pp = tm->tcpm_next; + rcu_assign_pointer(*pp, tm->tcpm_next); kfree_rcu(tm, rcu_head); } else { pp = &tm->tcpm_next; @@ -949,7 +949,7 @@ static int tcp_metrics_nl_cmd_del(struct sk_buff *skb, struct genl_info *info) if (addr_same(&tm->tcpm_daddr, &daddr) && (!src || addr_same(&tm->tcpm_saddr, &saddr)) && net_eq(tm_net(tm), net)) { - *pp = tm->tcpm_next; + rcu_assign_pointer(*pp, tm->tcpm_next); kfree_rcu(tm, rcu_head); found = true; } else { |